fix #2365: Hermes does not fully support ConstAndLet
#2372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecreeth
reviewed
Jul 5, 2022
Comment on lines
394
to
-395
| Firefox: {{start: v{51, 0, 0}}}, | ||
| Hermes: {{start: v{0, 7, 0}}}, |
There was a problem hiding this comment.
This file is generated by "compat-table.js".
I think that the way to go is add hermes0: false here
esbuild/scripts/compat-table.js
Line 145 in 71be8bc
|
Maybe it should be fixed on the |
|
It turned out that this was a bug with esbuild’s table generation script, not with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Hermes from
ConstAndLetas it does not fully support it.Resolves #2365.