[irteus/irtviewer.l] support changing floor color.

[mmurooka]

Ex1) Set floor line color black.

(make-irtviewer)
(send *irtviewer* :change-background (float-vector 1 1 1))
(send *irtviewer* :set-val 'x::draw-floor 100)
(send *irtviewer* :set-val 'x::floor-color #f(0 0 0))
(send *irtviewer* :draw-objects)

Ex2) Default color is white, which is same as before. So, visualization result does not change if you do not set floor color.

(make-irtviewer)
(send *irtviewer* :set-val 'x::draw-floor 100)
(send *irtviewer* :draw-objects)

[mmurooka]

I use this branch in Ubuntu 14.04 (indigo) / 16.04 (kinetic) for one week, and have no problem. I'm grad if someone review this.

[Affonso-Gui]

Worked for me too.

Might be nice to have a setter function, instead of using :set-val.

[YoheiKakiuchi]

Might be nice to have a setter function, instead of using :set-val.

+1

[mmurooka]

Thank you for review!

I think setter function is necessary for draw-origin, draw-floor, and floor-color.
https://github.com/euslisp/jskeus/blob/master/irteus/irtviewer.l#L65-L66

What name is good for setter function? :draw-floor or :set-draw-floor ?

[mmurooka]

Might be nice to have a setter function, instead of using :set-val.

added methods to set slot variables.

(make-irtviewer)

(make-irtviewer)
(send *irtviewer* :set-draw-floor 100)
(send *irtviewer* :draw-objects)

(make-irtviewer)
(send *irtviewer* :change-background (float-vector 1 1 1))
(send *irtviewer* :set-draw-floor 100)
(send *irtviewer* :set-floor-color #f(0 0 0))
(send *irtviewer* :draw-objects)

[k-okada]

@mmurooka can you update
https://github.com/euslisp/jskeus/tree/master/doc as well?

[mmurooka]

added document.

method定義のところに簡単なコメントは書いてあったので，それ以上のドキュメントとなると，このような感じでしょうか．（それともmethod定義のところを充実させるほうが良い？ただ図が貼れないですね．）

[k-okada]

*これって、make-irtviewer :floor-colorが可能なのかな？であれば、* *たとえば* *http://euslisp.github.io/jskeus/jmanual-node175.html <http://euslisp.github.io/jskeus/jmanual-node175.html>* *の以下の表示が変わるとわかりやすいな、と思うんですが、どうでしょうか。* *make-irtviewer* *&rest args *[関数] Create irtviewer :view-name title :hither near cropping plane :yon far cropping plane :width width of the window :height height of the window :draw-origin size of origin arrow, use nil to disable it :draw-floor use t to view floor 2018年12月12日(水) 17:12 Masaki Murooka <[email protected]>:

added document. method定義のところに簡単なコメントは書いてあったので，それ以上のドキュメントとなると，このような感じでしょうか．（それともmethod定義のところを充実させるほうが良い？ただ図が貼れないですね．） [image: screenshot from 2018-12-12 17-07-35] <https://user-images.githubusercontent.com/6636600/49855554-f9585080-fe30-11e8-9530-5cd071bcb386.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#528 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeG3E1g_CTnqNBdSNwOY4dh06zDxGOSks5u4LpbgaJpZM4XSkLL> .

-- -- ◉ Kei Okada

[mmurooka]

これって、make-irtviewer :floor-colorが可能なのかな？であれば、

可能です．0df8406 でコメント加えました．
（make-irtviewerで床の有無や色を指定する決まりにすれば，:set-floor-colorとかのmethodはいらなかったのかも，という気もする？）

fb82f4d のcommitは冗長であれば，rebaseで消します．

[k-okada]

@mmurooka something wrong with you last commit, I think having 'set-floor-coloris ok, but I feelsend irtviewr :floor-color #f(1 2 3)and(setq floor-color (send irtviewer :floor-color))` looks familiar to me.

)) (./irtviewer.tex
LaTeX Warning: Reference `fig:irtviewer' on page 268 undefined on input line 3.
! LaTeX Error: File `fig/irtviewer.xbb' not found. Use -shell-escape option to 
generate automatically.
See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.9 ...[width=0.50\columnwidth]{fig/irtviewer.png}
                                                  
? 
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: 

[mmurooka]

something wrong with you last commit,

Fixed.

I think having 'set-floor-coloris ok, but I feelsend irtviewr :floor-color #f(1 2 3)and(setq floor-color (send irtviewer :floor-color))` looks familiar to me.

Setting nil is important for draw-floor slot variable in order to disable floor visualization.
Do you have any idea to do both of (send irtviewer :draw-floor nil) for disabling visualization and (setq draw-floor (send irtviewer :draw-floor)) for getting current state in Euslisp?

[k-okada]

Please look at jsk/pfilter.l: (:debug (&optional (d :null)) (if (not (eq d :null)) (setq debug d)) debug) 2018年12月13日(木) 0:17 Masaki Murooka <[email protected]>:

something wrong with you last commit, Fixed. I think having 'set-floor-coloris ok, but I feelsend irtviewr :floor-color #f(1 2 3)and(setq floor-color (send irtviewer :floor-color))` looks familiar to me. Setting nil is important for draw-floor slot variable in order to disable floor visualization. Do you have any idea to do both of (send irtviewer :draw-floor nil) for disabling visualization and (setq draw-floor (send irtviewer :draw-floor)) for getting current state in Euslisp? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#528 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeG3AwCZL6VRzGV8xsrLDC5yQyizyBMks5u4R4MgaJpZM4XSkLL> .

-- -- ◉ Kei Okada

[mmurooka]

Please look at jsk/pfilter.l: (:debug (&optional (d :null)) (if (not (eq d :null)) (setq debug d)) debug)

Thank you, fixed.