-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add :init to ratio #373
Add :init to ratio #373
Conversation
@@ -1,4 +1,6 @@ | |||
(defmethod ratio | |||
(:prin1 (&optional (strm t)) | |||
(format strm "~d/~d" numerator denominator)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Affonso-Gui why you removed prin1
?, please also update doc/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed prin1
because
printratio
is already doing the job https://github.com/euslisp/EusLisp/blob/master/lisp/c/printer.c#L219-L226extnum.l
and its:prin1
method are currently not being loaded in euslisp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail/pass as expected |
@k-okada Please review |
@Affonso-Gui do we have a document for this? |
@k-okada Currently we have no documentation for |
yes please |
Add extended-number doc add :init to complex number c.f #373
Current:
Proposed:
Not sure if all the makefile changes are necessary (although seem to be sufficient).