Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: story image text slide scroller #2344

Merged
merged 24 commits into from
Jun 10, 2024
Merged

feat: story image text slide scroller #2344

merged 24 commits into from
Jun 10, 2024

Conversation

LeoniePeters
Copy link
Contributor

@LeoniePeters LeoniePeters commented Jun 5, 2024 •
edited
Loading

  • Adds new StoryImageTextSlideScroller component
    • contains sticky images over which the slide cards scroll
    • the corresponding image is transitioned into view when card enters the viewport
  • Refactors StoryPost to be able to split out the StoryImageTextSlideScroller sections from the browse sections and render them outside the container wrapper (allowing full screen display)
  • Refactor StoryHero scroll animation to not be dependent on placement at the top of the window
  • Rename hero object prop to heroImage in story page and child components
  • Updates the style guide:
    • Adds imagesWithAttribution sample data
    • Add StoryHero and StoryImageTextSlideScroller components

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

JIRA ticket: EC-6814

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Preview deployment: https://pr-2344.portal-js.dev.eanadev.org/

LeoniePeters and others added 18 commits June 5, 2024 11:23
@LeoniePeters
Rename appearDisappearSlideImage method and fix transition sliding up
eb7c827
@LeoniePeters
Add unit tests for StoryImageTextSlideScroller
0bb5872
@LeoniePeters
Increase size limit
8fc867a
@LeoniePeters
Fix for hero Safari
e7c6097
@LeoniePeters
Add StoryImageTextSlideScroller to style guide
c6de2ed
@LeoniePeters
Rename hero object to heroImage
f2d2cca
@LeoniePeters
Add StoryHero to styleguide and fix scroll animation when hero not at…
da75f48 
… top document
@LeoniePeters
Update unit tests
6f316fb
@LeoniePeters
Merge branch 'master' into feat/EC-6814-image-text-slide-scroller
2c9023b
@LeoniePeters
Increase size limit
cd90638
@rwd
chore: rm unnecessary eslint comment
64c0125
@rwd
chore: spelling
abd3cc6
@rwd
refactor: simplify splitSections
a10cb0b
@rwd
refactor: make BrowseSections render StoryImageTextSlideScroller
d14d30f
@rwd
Merge branch 'master' into feat/EC-6814-image-text-slide-scroller-Bro…
4442a2b 
…wseSections-StoryImageTextSlideScroller
@LeoniePeters
Remove authored-section class for scrollify section
3e0b285
@LeoniePeters
Remove wrapper div and add data-qa attribute to scrollify ContentSection
311bd1d
@rwd
Merge branch 'master' into feat/EC-6814-image-text-slide-scroller
a5757c0
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rwd rwd merged commit 095419c into master Jun 10, 2024
15 of 17 checks passed
@rwd rwd deleted the feat/EC-6814-image-text-slide-scroller branch June 10, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoniePeters @rwd