feat: exact match modifier for fulltext #2208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JIRA ticket: EC-6647 |
lbiedinger
changed the title
|
Preview deployment: https://pr-2208.portal-js.dev.eanadev.org/ |
rwd
requested changes
Mar 12, 2024
| @@ -12,7 +12,7 @@ const FIELD_SUGGEST_CONCEPT = 'concept'; | |||
| const FIELD_SUGGEST_PLACE = 'place'; | |||
|
|
|||
| const advancedSearchFields = [ | |||
| { name: 'fulltext', type: FIELD_TYPE_FULLTEXT }, | |||
| { name: 'fulltext', type: FIELD_TYPE_FULLTEXT, supportsExact: true }, | |||
There was a problem hiding this comment.
Instead of adding supportsExact to specific fields, derive it from the fact the the field type has a query property in the exact modifier.
packages/portal/src/lang/en.js
Outdated
| @@ -1078,6 +1078,7 @@ export default { | |||
| "individual": "Individual fields" | |||
| }, | |||
| "modifiers": { | |||
| "exact": "exact match", | |||
There was a problem hiding this comment.
It would be better if this made grammatical sense when the full rule is read, which Full-text exact match european union does not (whereas Full-text contains european union does).
| text: this.$t(`search.advanced.modifiers.${mod.name}`) | ||
| })) | ||
| options: this.advancedSearchModifiers.map((mod) => { | ||
| if (mod.name === 'exact' && (this.field !== this.fulltextFieldName)) { |
There was a problem hiding this comment.
This should be derived instead of hard-coded. See comment re supportsExact in the mixin.
|
|
See #2256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.