chore: card-labels for stories feature (#2341)

* no card-labels for stories feature * remove stories section labels; keep on browse pages * revert hiding card sub-titles for stories/exhibitions
europeana · Jun 5, 2024 · c7e4dfb · c7e4dfb
1 parent 9a4458d
commit c7e4dfb
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/packages/portal/src/components/content/ContentCard.vue b/packages/portal/src/components/content/ContentCard.vue
@@ -313,7 +313,7 @@
     data() {
       return {
         cardImageUrl: this.imageUrl,
-        displayLabelTypes: 'exhibitions|galleries|blog|collections',
+        displayLabelTypes: 'exhibitions|galleries|blog|collections|stories',
         // hit prefix & suffix can be overly long for our display purposes;
         // limit to max num of words each
         hitTextPrefix: this.hitText?.prefix?.split(/\s/).slice(-HIT_TEXT_AFFIX_MAX_WORDS).join(' '),
@@ -350,7 +350,7 @@
         }
 
         if (this.displayLabelType === 'blog') {
-          return this.$tc('blog.posts', 1);
+          return this.$features?.redirectBlogsToStories ? this.$tc('stories.stories', 1) : this.$tc('blog.posts', 1);
         }
 
         return this.$tc(`${this.displayLabelType}.${this.displayLabelType}`, 1);
@@ -361,7 +361,7 @@
       },
 
       displayLabelType() {
-        return this.displayLabelMatch ? this.displayLabelMatch[1] : false;
+        return this.displayLabelMatch?.[1];
       },
 
       displayLabelMatch() {

diff --git a/packages/portal/src/components/content/ContentHubPage.vue b/packages/portal/src/components/content/ContentHubPage.vue
@@ -25,7 +25,6 @@
               :image-optimisation-options="{ width: 510 }"
               :image-alt="imageAlt(item.primaryImageOfPage)"
               :texts="[item.description]"
-              :show-subtitle="false"
               :offset="index"
             />
           </b-card-group>

diff --git a/packages/portal/src/components/story/StoryPost.vue b/packages/portal/src/components/story/StoryPost.vue
@@ -5,7 +5,7 @@
       :title="title"
       :subtitle="subtitle"
       :hero="hero"
-      :context-label="$t('cardLabels.story')"
+      :context-label="$tc('stories.stories', 1)"
       data-qa="story hero"
     />
     <AuthoredHead
@@ -14,7 +14,7 @@
       :subtitle="subtitle"
       :description="description"
       :hero="hero"
-      :context-label="$t('cardLabels.story')"
+      :context-label="$tc('stories.stories', 1)"
       data-qa="authored head"
     />
     <div

diff --git a/packages/portal/src/i18n/lang/en.js b/packages/portal/src/i18n/lang/en.js
@@ -107,7 +107,6 @@ export default {
     "organisation": "Organisation",
     "person": "Person",
     "place": "Place",
-    "story": "Story",
     "theme": "Theme",
     "time": "Century",
     "topic": "Topic"
@@ -1230,8 +1229,10 @@ export default {
     "pinned": "Pinned",
     "required": "Required"
   },
+  "stories": {
+    "stories": "Story | Stories"
+  },
   "storiesPage": {
-    "title": "Stories",
     "storiesHaveLoaded": "{0} stories found"
   },
   "swiper": {

diff --git a/packages/portal/src/pages/stories/index.vue b/packages/portal/src/pages/stories/index.vue
@@ -90,7 +90,7 @@
     computed: {
       pageMeta() {
         return {
-          title: this.$t('storiesPage.title'),
+          title: this.$tc('stories.stories', 2),
           description: this.description,
           ogType: 'article',
           ogImage: this.socialMediaImage?.url,

diff --git a/packages/portal/tests/unit/pages/stories/index.spec.js b/packages/portal/tests/unit/pages/stories/index.spec.js
@@ -101,7 +101,7 @@ describe('pages/stories/index', () => {
 
         const pageMeta = wrapper.vm.pageMeta;
 
-        expect(pageMeta.title).toBe('storiesPage.title');
+        expect(pageMeta.title).toBe('stories.stories');
       });
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -101,7 +101,7 @@ describe('pages/stories/index', () => { @@
             const pageMeta = wrapper.vm.pageMeta;
-            expect(pageMeta.title).toBe('storiesPage.title');
+            expect(pageMeta.title).toBe('stories.stories');
           });
         });
@@ Expand Down @@