Correct DELETED tuple reference pg_decode_change_v1 #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I build and run wal2json's regression tests, test "pk" fails and the Postgres backend process crashes with this error:
Upon some debugging, I notice that wal2json references
newtuple
under theREORDER_BUFFER_CHANGE_DELETE
case inpg_decode_change_v1()
when callingpk_to_stringinfo()
but it seems like we should use the old tuple. If I replace it witholdtuple
, the test passes.Can we confirm if we should pass
oldtuple
topk_to_stringinfo()
?