fix(mockResponse): writeHead() sets headersSent. (#313)

eugef · Dec 9, 2024 · 8618dd8 · 8618dd8
1 parent 7297984
commit 8618dd8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/lib/mockResponse.js b/lib/mockResponse.js
@@ -141,6 +141,7 @@ function createResponse(options = {}) {
             Object.assign(mockResponse._headers, utils.convertKeysToLowerCase(headers));
         }
 
+        this.headersSent = true;
         return this;
     };
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/lib/mockResponse.spec.js b/test/lib/mockResponse.spec.js
@@ -870,10 +870,8 @@ describe('mockResponse', () => {
 
             it('updates the headersSent property of the response', () => {
                 const headers = { 'x-header': 'test llama' };
-                response.writeHead(400, headers);
-                // headers are only sent by node with first body byte
                 expect(response.headersSent).to.equal(false);
-                response.write('foo');
+                response.writeHead(400, headers);
                 expect(response.headersSent).to.equal(true);
                 // further updates to headers shouldn't really be reflected in mock headers
                 // since these would be transmitted as part of the body (probably breaking chunked encoding)
-Original file line number
+Diff line change
@@ Expand Up / @@ -141,6 +141,7 @@ function createResponse(options = {}) { @@
                 Object.assign(mockResponse._headers, utils.convertKeysToLowerCase(headers));
             }
+            this.headersSent = true;
             return this;
         };
@@ Expand Down @@