sync src/scsi_id/scsi_id.c #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some important changes are there, this should be ready to merge after a review |
systemd-commit: ebc6f34a0b2359ac0da41037a1122d3abe02caee Author: Jan Synacek <[email protected]> Date: Wed Aug 2 10:12:33 2017 +0200
Previously, the value is once stringified, and later again parsed, that is completely redundant. Follow-up for 1001167ca5e4cfdc6230562e4fb9029e5f624d53. Replaces #20013. systemd-commit: 4dce1b9f059733ed9a263fba7cfa12704e96794a Author: Yu Watanabe <[email protected]> Date: Fri Jun 25 15:04:12 2021 +0900
gcc was warning about strncpy() leaving an unterminated string. In this case, it was correct. The code was doing strncpy()+strncat()+strlen() essentially to determine if the strings have expected length. If the length was correct, a buffer overread was performed (or at least some garbage bytes were used from the uninitialized part of the buffer). Let's do the length check first and then only copy stuff if everything agrees. For some reason the function was called "prepend", when it obviously does an "append". systemd-commit: 099c77fd5ff835614dea8dc11c57f6d44f77d9ee Author: Zbigniew Jędrzejewski-Szmek <[email protected]> Date: Tue May 7 15:58:29 2019 +0200
The prefix for EMC Symmetrix pre-SPC VPD inquiry reply is always SCSI_ID_NAA, so we need to hardcode it to avoid false values here. Signed-off-by: Hannes Reinecke <[email protected]> systemd-commit: c0373eb019db70017878ee64d042de902e4c98ee Author: Hannes Reinecke <[email protected]> Date: Wed Sep 13 09:08:28 2017 +0200
…n VPD page The length of device identification VPD page is filled with two bytes, but scsi_id only gets the low byte. Fix it. Signed-off-by: Zhang Xianwei <[email protected]> systemd-commit: 1f7b6872dbe8ccae1f3bda9aa6aeb87c9b42e01e Author: Zhang Xianwei <[email protected]> Date: Mon May 13 18:41:55 2019 +0800
kaniini
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Jan Synacek [email protected]
Date: Wed Aug 2 10:12:33 2017 +0200
scsi_id: add missing options to getopt_long() (#6501)
systemd-commit: ebc6f34a0b2359ac0da41037a1122d3abe02caee