Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default model option when selecting a different region #60

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

geek-yang
Copy link
Member

This PR fixes #56 .

@geek-yang geek-yang requested a review from bvreede April 6, 2022 10:06
Copy link
Member

@bvreede bvreede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It would be nice however to keep the selection of the model if this is possible. It is good that now an impossible combination no longer shows up, but if the combination region/model is possible, it would be nice not to lose the selected model when moving to another region.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@geek-yang
Copy link
Member Author

Looks good! It would be nice however to keep the selection of the model if this is possible. It is good that now an impossible combination no longer shows up, but if the combination region/model is possible, it would be nice not to lose the selected model when moving to another region.

Thanks for your comment @bvreede. Very good point! It is implemented now.

@bvreede
Copy link
Member

bvreede commented Apr 11, 2022

It's not working on my end... maybe we can look at it tomorrow at the office!

@geek-yang
Copy link
Member Author

It's not working on my end... maybe we can look at it tomorrow at the office!

Thanks for your review again. This is weird. It works on my machine. Let's take a look together tomorrow.

@bvreede bvreede self-requested a review April 12, 2022 11:42
Copy link
Member

@bvreede bvreede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it works now, magic! :)

@geek-yang geek-yang merged commit 9d0cc16 into main Apr 12, 2022
@geek-yang geek-yang deleted the fix-default-dropdown-model-selection branch April 12, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding "impossible" models when navigating between regions
2 participants