Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish notebooks and data #38

Merged
merged 41 commits into from
Nov 5, 2021
Merged

Polish notebooks and data #38

merged 41 commits into from
Nov 5, 2021

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Oct 29, 2021

closes #40

Notebooks need raw data. The AtlasData dir available in EUCP sharepoint, has two folders: raw and preprocess.
The previous data is archived in AtlasData_v0.zip and available in EUCP sharepoint, too.

The maps re-generated with these refactored codes in this branch are the same as the main branch, except for ASK to fix issue #40 and for UKCP because we got revised data.

sverhoeven added a commit that referenced this pull request Nov 2, 2021
The environment.yml will be available once #38 is merged.
@SarahAlidoost SarahAlidoost marked this pull request as ready for review November 2, 2021 11:15
@sverhoeven
Copy link
Member

Was able to create env with environment.yml, and documented it in https://github.com/eucp-project/atlas/blob/basic_docs/python/README.md#requirements as part of PR #43

@Peter9192
Copy link
Member

Following @sverhoeven suggestion in #50, I enabled nbreview to aid in reviewing this PR: https://app.reviewnb.com/eucp-project/atlas/pull/38/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

Really nice work you've done here Sarah! Somehow some of the outputs don't render in reviewNB, but they are present locally. So the IPSL/Cordex notebook is now integrated into the IPSL/REA notebook, right?

I took the liberty of pushing a commit that formats all the notebooks using black, hope that's okay.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bvreede
Copy link
Member

bvreede commented Nov 4, 2021

Data is on zenodo and has a DOI: 10.5281/zenodo.5645154

Markdown badge:
DOI
[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.5645154.svg)](https://doi.org/10.5281/zenodo.5645154)

Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SarahAlidoost Thanks for your awesome work! It even took me a while to review all the changes. That's a massive amount of work.

It is nice to see that now even the cordex files are preprocessed and grouped as independent files. This looks cleaner to the user and makes the whole workflow generic. Thanks again for the polishing. I think it is ready for merging.

@SarahAlidoost
Copy link
Member Author

Really nice work you've done here Sarah! Somehow some of the outputs don't render in reviewNB, but they are present locally. So the IPSL/Cordex notebook is now integrated into the IPSL/REA notebook, right?

Right, the notebook maps_creator_IPSL_cordex is now removed. Some codes are moved to the notebook cleanup_IPSL_REA. Now the maps of cordex can be created by the python script maps_creator_atlas_data.py.

I took the liberty of pushing a commit that formats all the notebooks using black, hope that's okay.

@SarahAlidoost
Copy link
Member Author

@SarahAlidoost Thanks for your awesome work! It even took me a while to review all the changes. That's a massive amount of work.

It is nice to see that now even the cordex files are preprocessed and grouped as independent files. This looks cleaner to the user and makes the whole workflow generic. Thanks again for the polishing. I think it is ready for merging.

Thanks for reviewing.

@SarahAlidoost SarahAlidoost merged commit 14ee63d into main Nov 5, 2021
@SarahAlidoost SarahAlidoost deleted the polish_data branch November 5, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASK constrained maps are not correct
5 participants