-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish notebooks and data #38
Conversation
The environment.yml will be available once #38 is merged.
Was able to create env with environment.yml, and documented it in https://github.com/eucp-project/atlas/blob/basic_docs/python/README.md#requirements as part of PR #43 |
Following @sverhoeven suggestion in #50, I enabled nbreview to aid in reviewing this PR: https://app.reviewnb.com/eucp-project/atlas/pull/38/ |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Really nice work you've done here Sarah! Somehow some of the outputs don't render in reviewNB, but they are present locally. So the IPSL/Cordex notebook is now integrated into the IPSL/REA notebook, right?
I took the liberty of pushing a commit that formats all the notebooks using black, hope that's okay.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SarahAlidoost Thanks for your awesome work! It even took me a while to review all the changes. That's a massive amount of work.
It is nice to see that now even the cordex files are preprocessed and grouped as independent files. This looks cleaner to the user and makes the whole workflow generic. Thanks again for the polishing. I think it is ready for merging.
Right, the notebook
|
Thanks for reviewing. |
closes #40
Notebooks need raw data. The
AtlasData
dir available in EUCP sharepoint, has two folders:raw
andpreprocess
.The previous data is archived in
AtlasData_v0.zip
and available in EUCP sharepoint, too.The maps re-generated with these refactored codes in this branch are the same as the main branch, except for ASK to fix issue #40 and for UKCP because we got revised data.