Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ccby logo for images #29

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Add ccby logo for images #29

merged 5 commits into from
Nov 5, 2021

Conversation

SarahAlidoost
Copy link
Member

relates #13

@SarahAlidoost
Copy link
Member Author

@Peter9192 the marge can be done later, but the implementation can be reviewed. thanks.

Peter9192
Peter9192 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I like the link to the official creative commons page.
For now it's good as is, but indeed, let's wait with merging. Depending on progress on other work items, we might change the "more info" link to the "references" page before merging.

components/Atlas.vue Outdated
>
<p class="absolute bottom-6 left-1/3 text-center text-sm">
Figures can be used under a CC-BY 4.0 licence,
see More info on how to cite.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if "more info" was actually a link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'more info' button will be removed, right? Perhaps best to link directly to the CC site. It contains enough information on how to work with the CC-BY license.

@bvreede bvreede self-requested a review October 27, 2021 12:43
bvreede
bvreede reviewed Oct 27, 2021
View reviewed changes
components/Atlas.vue Outdated
>
<p class="absolute bottom-6 left-1/3 text-center text-sm">
Figures can be used under a CC-BY 4.0 licence,
see More info on how to cite.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'more info' button will be removed, right? Perhaps best to link directly to the CC site. It contains enough information on how to work with the CC-BY license.

components/Atlas.vue Outdated Show resolved Hide resolved
@SarahAlidoost SarahAlidoost marked this pull request as ready for review November 4, 2021 15:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SarahAlidoost SarahAlidoost merged commit ade6e82 into main Nov 5, 2021
@SarahAlidoost SarahAlidoost deleted the add_maps_license branch November 5, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvreede bvreede bvreede left review comments

@Peter9192 Peter9192 Peter9192 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarahAlidoost @bvreede @Peter9192