-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library licenses without proprietary dependency #55
Library licenses without proprietary dependency #55
Conversation
@Wv5twkFEKh54vo4tta9yu7dHa3 thank you for your contribution! |
Oh, is this supposed to be used by member states and re-branded? That's disappointing, I would've liked an EU-branded app for once :( |
Ultimately this is up to the European Commission, but the current status is indeed that the apps here are ready-to-use templates that member states can re-brand or partially include in existing national COVID19-related apps. That said, I can still see it being useful to think about #50 and this PR, so others can build upon this, but we have to verify if it is in scope as this is not up to us |
Thanks for your reply. This PR should be merged regardless of #50 I would say, since it would be somewhat of a shame to have a proprietary dependency on GMS for no reason |
FYI, I'm the original contributor of this activity/fragment in Mozilla Fenix (https://github.com/mozilla-mobile/fenix/pull/13767/files), and I also released a copy of this code into public domain, so license shouldn't be a concern for anyone: https://gist.github.com/gilbsgilbs/36724e7752c55ebb99bf9e59b1c96706 . As for #50 being in-scope or not, I still think it'd be better to not include proprietary dependencies (especially from Google) in a template that may spread across EU, regardless of whether or not this app is expected to land into third-party stores. |
9403481
into
eu-digital-green-certificates:main
Thanks 💙. |
As part of fixing #50, this removes the dependency on the proprietary Google Licenses activity, and replaces it with a free implementation
Related to #37
Please note, this was inspired by mozilla-mobile/fenix#13767 and as such the LicensesActivity is under the MPL 2.0. I have reached out to the author to ask for a copy of the corresponding file under Apache 2.0, but even if that ends up not being possible it should also be noted that the MPL is compatible with Apache 2.0.