-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Text variants not working correctly on Android #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
brightlayer-ui
Used to identify Brightlayer UI platform issues for easy filtering
label
Mar 28, 2024
ektaghag-eaton
requested review from
manojleaton,
ArshdeepSingh3-eaton and
priyankakmEaton
March 28, 2024 10:30
also to prepare for publishing we should have change log entry for this and since we can't run the demo as is how do we want to verify all the font variants....since we are only removing the fontWeight from here I suspect it will be fine |
Hi @JeffGreiner-eaton , I have updated the changelog. Please check. |
JeffGreiner-eaton
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 89 .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
Android
To Test:
Any specific feedback you are looking for?