Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Text variants not working correctly on Android #90

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

ektaghag-eaton
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton commented Mar 28, 2024

Fixes 89 .

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

Android
Screenshot 2024-03-28 at 6 23 13 PM

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Mar 28, 2024
@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Mar 28, 2024

also to prepare for publishing we should have change log entry for this and since we can't run the demo as is how do we want to verify all the font variants....since we are only removing the fontWeight from here I suspect it will be fine

@ektaghag-eaton
Copy link
Contributor Author

was anyone able to run showcase demo from this repo? guessing wrapper components won't work since we don't have anymore

Not able to run showcase in theme repo. I tried to copy changes of node modules in RN workflow example's project /Users/e0643697/Documents/BLUI/Smoke Test/blui-react-native-workflows/login-workflow/example/node_modules/@brightlayer-ui/react-native-themes/dist/shared.js

@ektaghag-eaton
Copy link
Contributor Author

Hi @JeffGreiner-eaton , I have updated the changelog. Please check.

@ektaghag-eaton ektaghag-eaton merged commit bca457e into dev Apr 1, 2024
1 check passed
@ektaghag-eaton ektaghag-eaton deleted the fix/android-text-variant branch April 1, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

Text variants not working correctly on Android
2 participants