Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation for components #80

Merged
merged 11 commits into from
Jan 12, 2024

Conversation

ArshdeepSingh3-eaton
Copy link

Fixes # .

Changes proposed in this Pull Request:

  • Added template documentation for Progressbar and Snackbar

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

  • Please Review and provide input if the document needs some updation

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2024
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just suggestion see what others say

RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
@ArshdeepSingh3-eaton ArshdeepSingh3-eaton marked this pull request as ready for review January 10, 2024 11:05
Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to link to this page from somewhere in (1) this repo's readme, and (2) maybe this migration guide too?

RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
RNPComponents/RNPComponents.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ektaghag-eaton ektaghag-eaton self-requested a review January 12, 2024 10:58
@ektaghag-eaton ektaghag-eaton merged commit be6dd27 into dev Jan 12, 2024
1 check passed
@ektaghag-eaton ektaghag-eaton deleted the feature/blui-5037-RNPdocumentation branch January 12, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

4 participants