Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to custom colors in RNP theme #59

Merged

Conversation

manojleaton
Copy link
Contributor

Fixes #BLUI-4937 .

Changes proposed in this Pull Request:

  • Added comments to the custom color variants

Screenshots / Screen Recording (if applicable)

To Test:

  • yarn start:showcase

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Nov 30, 2023
@manojleaton manojleaton requested a review from huayunh November 30, 2023 09:13
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JeffGreiner-eaton
Copy link
Collaborator

Is this documentation for end users intellisense or on hovers?

Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and detailed.

@manojleaton
Copy link
Contributor Author

Is this documentation for end users intellisense or on hovers?

We have added these comments to all of the custom colors for our internal development reference and for end users

@manojleaton manojleaton merged commit fb69b56 into dev Dec 1, 2023
1 check passed
@manojleaton manojleaton deleted the feature/4937-Add-comments-to-custom-colors-in-RNP-theme branch December 1, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

4 participants