-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blueDarkAlt theme deprecation notice for v6.0.0 #10
Conversation
I've seen other depreciations also note the replacement of the named import. Should we do this as well? |
There's not really a "replacement" import per se. They would now just exclusively use the blueDark theme and potentially our new wrapper components, depending on the use case. |
So I assumed that the AltThemeProvider was in this repo, but it looks like it’s local to the auth workflow. We will probably want to add a deprecation warning there too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to throw a console.warn in this file so that users will actually get a warning in the log (not just intellisense on hover). I think if you just drop it above the definition for the alt theme it should spit out the warning if anybody imports anything from that file.
guess we could call out the updated import in the dep comment? use blueDark Like the testing I was doing last week with Angular the 'get.testBed' was deprecated and it had a comment.. just an idea not a big deal |
add console warning add alternative theme usage notice
yeah weird it doesn't show. I'm not familiar with this but is the @see still something that's used? I set it in my local d.ts file. Do we have control on the quick fix link above? right now the quick fix is just remove the import (can it be change import to blueDark instead? |
@jeffvg that |
for me I see this when I hover over the striked through import name.. (the @see is here on my local) |
ok this makes sense. Projects using ^5.1.0 of the theme would see the warning and depreciation info. |
Fixes PXBLUE-2453.
Changes proposed in this Pull Request:
Additional Context
This is what it looks like if you try to import the darkThemeAlt theme into a project.