Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2785 Updated the dependencies to the latest version #48

Closed
wants to merge 11 commits into from
Closed

2785 Updated the dependencies to the latest version #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8aa6072
2785 Updated the dependencies to the latest version
bkarambe Jan 7, 2022
c30b6b3
2785 Reverted the node engine unsupported deps
bkarambe Jan 7, 2022
2fa43a9
2785 Updated typescript-eslint deps
bkarambe Jan 7, 2022
4d39a11
Updated node version in config yml
bkarambe Jan 7, 2022
7f35411
Regenrated yarn lock files
bkarambe Jan 7, 2022
425ed98
2785 Added a typecasting for failing lint
bkarambe Jan 7, 2022
ebb6afb
2785 Updated blank project dependencies
bkarambe Jan 7, 2022
7476df0
Updated authentication dependencies
bkarambe Jan 7, 2022
a8743fe
Updated routing dependencies
bkarambe Jan 7, 2022
482d2c3
Updated dependencies
bkarambe Jan 7, 2022
b4f1e61
Updated dependencies in root package
bkarambe Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ orbs:
jobs:
build_project:
docker:
- image: circleci/node:12.9.1-browsers
- image: circleci/node:14.18.1-browsers
working_directory: ~/react-native-cli-templates
steps:
- checkout
Expand All @@ -30,7 +30,7 @@ jobs:

publish:
docker:
- image: circleci/node:12.9.1-browsers
- image: circleci/node:14.18.1-browsers
steps:
- checkout
- run:
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:

tag:
docker:
- image: circleci/node:12.9.1-browsers
- image: circleci/node:14.18.1-browsers
steps:
- checkout
- gh/setup
Expand Down
46 changes: 23 additions & 23 deletions authentication-typescript/dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
{
"dependencies": [
"@brightlayer-ui/colors@^3.0.1",
"@brightlayer-ui/icons-svg@^1.8.0",
"@brightlayer-ui/icons-svg@^1.8.1",
"@brightlayer-ui/react-native-auth-workflow@^4.0.0",
"@brightlayer-ui/react-native-components@^6.0.1",
"@brightlayer-ui/react-native-components@^6.0.2",
"@brightlayer-ui/react-native-themes@^6.0.0",
"@brightlayer-ui/react-native-vector-icons@^1.4.0",
"@react-native-async-storage/async-storage@^1.14.1",
"@react-native-community/masked-view@^0.1.10",
"@react-navigation/drawer@^5.12.3",
"@react-navigation/native@^5.9.3",
"@react-navigation/stack@^5.14.3",
"date-fns@^2.19.0",
"i18next@^20.0.0",
"react-i18next@^11.8.7",
"react-native-gesture-handler@^1.10.3",
"react-native-keyboard-aware-scroll-view@^0.9.3",
"react-native-modal@^12.0.2",
"react-native-pager-view@^5.0.0",
"react-native-paper@^4.7.2",
"react-native-reanimated@^1.0.0",
"react-native-safe-area-context@^3.2.0",
"react-native-screens@^3.0.0",
"react-native-svg@^12.1.0",
"react-native-svg-transformer@^0.14.3",
"react-native-vector-icons@^8.1.0",
"react-native-webview@^10.3.2"
"@brightlayer-ui/react-native-vector-icons@^1.4.1",
"@react-native-async-storage/async-storage@^1.15.14",
"@react-native-community/masked-view@^0.1.11",
"@react-navigation/drawer@^6.1.8",
"@react-navigation/native@^6.0.6",
"@react-navigation/stack@^6.0.11",
"date-fns@^2.28.0",
"i18next@^21.6.5",
"react-i18next@^11.15.3",
"react-native-gesture-handler@^2.1.0",
"react-native-keyboard-aware-scroll-view@^0.9.5",
"react-native-modal@^13.0.0",
"react-native-pager-view@^5.4.9",
"react-native-paper@^4.11.1",
"react-native-reanimated@^2.3.1",
"react-native-safe-area-context@^3.3.2",
"react-native-screens@^3.10.1",
"react-native-svg@^12.1.1",
"react-native-svg-transformer@^1.0.0",
"react-native-vector-icons@^9.0.0",
"react-native-webview@^11.15.1"
],
"devDependencies": ["@types/react-native-vector-icons", "jest-transform-stub"]
}
2 changes: 1 addition & 1 deletion authentication-typescript/template/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const App = (): JSX.Element => {
const { getInitialState } = useLinking(ref, authLinkMapping);
const [initialState, setInitialState] = React.useState();
React.useEffect(() => {
resolveInitialState(getInitialState, setInitialState);
resolveInitialState(getInitialState as () => any, setInitialState as (state: any) => void);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be using the any type

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little tricky; getInitialState is the correct type already (even without the any cast) but the auth-ts template fails linting because it doesn't have access to the type definitions found within @react-navigation/native.

I'm confused as to why we're creating templates without having the required deps installed at the root level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this story is going to evolve into something larger than expected; how is linting working without the type dependencies installed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daileytj do you have thoughts on this one? We might need to update the root package.json so it contains all the dependencies that each template requires; this is how the angular one does it currently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root package.json absolutely should contain every dependency that is in any template

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it was initially written so that the demo project could run every template locally for testing purposes

}, [getInitialState]);

return (
Expand Down
46 changes: 23 additions & 23 deletions authentication/dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
{
"dependencies": [
"@brightlayer-ui/colors@^3.0.1",
"@brightlayer-ui/icons-svg@^1.8.0",
"@brightlayer-ui/icons-svg@^1.8.1",
"@brightlayer-ui/react-native-auth-workflow@^4.0.0",
"@brightlayer-ui/react-native-components@^6.0.1",
"@brightlayer-ui/react-native-components@^6.0.2",
"@brightlayer-ui/react-native-themes@^6.0.0",
"@brightlayer-ui/react-native-vector-icons@^1.4.0",
"@react-native-async-storage/async-storage@^1.14.1",
"@react-native-community/masked-view@^0.1.10",
"@react-navigation/drawer@^5.12.3",
"@react-navigation/native@^5.9.3",
"@react-navigation/stack@^5.14.3",
"date-fns@^2.19.0",
"i18next@^20.0.0",
"react-i18next@^11.8.7",
"react-native-gesture-handler@^1.10.3",
"react-native-keyboard-aware-scroll-view@^0.9.3",
"react-native-modal@^12.0.2",
"react-native-pager-view@^5.0.0",
"react-native-paper@^4.7.2",
"react-native-reanimated@^1.0.0",
"react-native-safe-area-context@^3.2.0",
"react-native-screens@^3.0.0",
"react-native-svg@^12.1.0",
"react-native-svg-transformer@^0.14.3",
"react-native-vector-icons@^8.1.0",
"react-native-webview@^10.3.2"
"@brightlayer-ui/react-native-vector-icons@^1.4.1",
"@react-native-async-storage/async-storage@^1.15.14",
"@react-native-community/masked-view@^0.1.11",
"@react-navigation/drawer@^6.1.8",
"@react-navigation/native@^6.0.6",
"@react-navigation/stack@^6.0.11",
"date-fns@^2.28.0",
"i18next@^21.6.5",
"react-i18next@^11.15.3",
"react-native-gesture-handler@^2.1.0",
"react-native-keyboard-aware-scroll-view@^0.9.5",
"react-native-modal@^13.0.0",
"react-native-pager-view@^5.4.9",
"react-native-paper@^4.11.1",
"react-native-reanimated@^2.3.1",
"react-native-safe-area-context@^3.3.2",
"react-native-screens@^3.10.1",
"react-native-svg@^12.1.1",
"react-native-svg-transformer@^1.0.0",
"react-native-vector-icons@^9.0.0",
"react-native-webview@^11.15.1"
],
"devDependencies": ["jest-transform-stub"]
}
20 changes: 10 additions & 10 deletions blank-typescript/dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
"dependencies": [
"@brightlayer-ui/react-native-themes@^6.0.0",
"@brightlayer-ui/colors@^3.0.1",
"@brightlayer-ui/react-native-components@^6.0.1",
"@brightlayer-ui/react-native-vector-icons@^1.4.0",
"react-native-modal@^12.0.2",
"react-native-paper@^4.7.2",
"@brightlayer-ui/icons-svg@^1.8.0",
"react-native-vector-icons@^8.0.0",
"react-native-svg@^12.1.0",
"react-native-gesture-handler@^1.10.2",
"react-native-svg-transformer@^0.14.3",
"react-native-safe-area-context@^3.2.0"
"@brightlayer-ui/react-native-components@^6.0.2",
"@brightlayer-ui/react-native-vector-icons@^1.4.1",
"react-native-modal@^13.0.0",
"react-native-paper@^4.11.1",
"@brightlayer-ui/icons-svg@^1.8.1",
"react-native-vector-icons@^9.0.0",
"react-native-svg@^12.1.1",
"react-native-gesture-handler@^2.1.0",
"react-native-svg-transformer@^1.0.0",
"react-native-safe-area-context@^3.3.2"
],
"devDependencies": ["@types/react-native-vector-icons", "jest-transform-stub"]
}
20 changes: 10 additions & 10 deletions blank/dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
"dependencies": [
"@brightlayer-ui/react-native-themes@^6.0.0",
"@brightlayer-ui/colors@^3.0.1",
"@brightlayer-ui/react-native-components@^6.0.1",
"@brightlayer-ui/react-native-vector-icons@^1.4.0",
"react-native-modal@^12.0.2",
"react-native-paper@^4.7.2",
"@brightlayer-ui/icons-svg@^1.8.0",
"react-native-vector-icons@^8.0.0",
"react-native-svg@^12.1.0",
"react-native-gesture-handler@^1.10.2",
"react-native-svg-transformer@^0.14.3",
"react-native-safe-area-context@^3.2.0"
"@brightlayer-ui/react-native-components@^6.0.2",
"@brightlayer-ui/react-native-vector-icons@^1.4.1",
"react-native-modal@^13.0.0",
"react-native-paper@^4.11.1",
"@brightlayer-ui/icons-svg@^1.8.1",
"react-native-vector-icons@^9.0.0",
"react-native-svg@^12.1.1",
"react-native-gesture-handler@^2.1.0",
"react-native-svg-transformer@^1.0.0",
"react-native-safe-area-context@^3.3.2"
],
"devDependencies": ["jest-transform-stub"]
}
72 changes: 36 additions & 36 deletions demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,54 +27,54 @@
},
"dependencies": {
"@brightlayer-ui/colors": "^3.0.1",
"@brightlayer-ui/icons-svg": "^1.7.0",
"@brightlayer-ui/react-native-auth-workflow": "^4.0.0-beta.0",
"@brightlayer-ui/react-native-components": "^6.0.1",
"@brightlayer-ui/icons-svg": "^1.8.1",
"@brightlayer-ui/react-native-auth-workflow": "^4.0.0",
"@brightlayer-ui/react-native-components": "^6.0.2",
"@brightlayer-ui/react-native-themes": "^6.0.0",
"@brightlayer-ui/react-native-vector-icons": "^1.3.1",
"@react-native-async-storage/async-storage": "^1.14.1",
"@react-native-community/masked-view": "^0.1.10",
"@brightlayer-ui/react-native-vector-icons": "^1.4.1",
"@react-native-async-storage/async-storage": "^1.15.14",
"@react-native-community/masked-view": "^0.1.11",
"@react-navigation/drawer": "^5.12.3",
"@react-navigation/native": "^5.9.3",
"@react-navigation/stack": "^5.14.3",
"date-fns": "^2.17.0",
"i18next": "^20.0.0",
"react": "^17.0.1",
"react-i18next": "^11.8.7",
"date-fns": "^2.28.0",
"i18next": "^21.6.5",
"react": "^17.0.2",
"react-i18next": "^11.15.3",
"react-native": "^0.63.4",
"react-native-gesture-handler": "^1.10.2",
"react-native-keyboard-aware-scroll-view": "^0.9.3",
"react-native-modal": "^11.6.1",
"react-native-pager-view": "^5.0.0",
"react-native-paper": "^4.7.2",
"react-native-gesture-handler": "^2.1.0",
"react-native-keyboard-aware-scroll-view": "^0.9.5",
"react-native-modal": "^13.0.0",
"react-native-pager-view": "^5.4.9",
"react-native-paper": "^4.11.1",
"react-native-reanimated": "^1.0.0",
"react-native-safe-area-context": "^3.1.9",
"react-native-screens": "^3.0.0",
"react-native-svg": "^12.1.0",
"react-native-svg-transformer": "^0.14.3",
"react-native-vector-icons": "^8.0.0",
"react-native-webview": "^11.2.3"
"react-native-safe-area-context": "^3.3.2",
"react-native-screens": "^3.10.1",
"react-native-svg": "^12.1.1",
"react-native-svg-transformer": "^1.0.0",
"react-native-vector-icons": "^9.0.0",
"react-native-webview": "^11.15.1"
},
"devDependencies": {
"@babel/core": "^7.8.4",
"@babel/runtime": "^7.8.4",
"@babel/core": "^7.16.7",
"@babel/runtime": "^7.16.7",
"@brightlayer-ui/eslint-config": "^2.0.5",
"@brightlayer-ui/prettier-config": "^1.0.3",
"@react-native-community/eslint-config": "^1.1.0",
"@types/jest": "^25.2.3",
"@react-native-community/eslint-config": "^1.0.3",
"@types/jest": "^27.4.0",
"@types/react-native": "^0.64.1",
"@types/react-native-vector-icons": "^6.4.6",
"@types/react-test-renderer": "^16.9.2",
"@typescript-eslint/eslint-plugin": "^4.5.0",
"@typescript-eslint/parser": "^4.5.0",
"babel-jest": "^25.1.0",
"eslint": "^7.11.0",
"eslint-config-prettier": "^6.13.0",
"eslint-plugin-react": "^7.0.0",
"jest": "^26.6.3",
"@types/react-native-vector-icons": "^6.4.10",
"@types/react-test-renderer": "^17.0.1",
"@typescript-eslint/eslint-plugin": "^5.9.0",
"@typescript-eslint/parser": "^5.9.0",
"babel-jest": "^27.4.6",
"eslint": "^8.6.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-react": "^7.28.0",
"jest": "^27.4.7",
"metro-react-native-babel-preset": "^0.59.0",
"react-test-renderer": "^17.0.1",
"typescript": "^3.8.3"
"react-test-renderer": "^17.0.2",
"typescript": "^4.5.4"
},
"jest": {
"preset": "react-native",
Expand Down
Loading