Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove calc from box components app content area #849

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Feb 9, 2024

Fixes #806.

Changes proposed in this Pull Request:

  • remove calc from box component

Screenshots / Screen Recording (if applicable)

  • iPad
image
  • iPhone
image

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (976ae15) 84.03% compared to head (f5d1af2) 84.03%.
Report is 8 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #849   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files          58       58           
  Lines        1234     1234           
  Branches      158      158           
=======================================
  Hits         1037     1037           
  Misses         98       98           
  Partials       99       99           
Flag Coverage Δ
unittests 84.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 9, 2024

Visit the preview URL for this PR (updated for commit f5d1af2):

https://blui-react-docs--pr849-fix-blui-5256-drawer-uuizxqif.web.app

(expires Sun, 11 Feb 2024 16:38:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

@JeffGreiner-eaton JeffGreiner-eaton marked this pull request as ready for review February 9, 2024 16:45
@ektaghag-eaton ektaghag-eaton self-requested a review February 12, 2024 06:50
@ektaghag-eaton ektaghag-eaton merged commit 53a00e8 into dev Feb 12, 2024
17 checks passed
@ektaghag-eaton ektaghag-eaton deleted the fix/blui-5256-drawer-mobile-view branch February 12, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

The playground component preview for the drawer component is not rendering on mobile
2 participants