Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nav item props to shared props #843

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Feb 6, 2024

Fixes #776.

Changes proposed in this Pull Request:

  • Added drawer nav item props (right now they are in the shared props file and will move to nav item doc)

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

  • Right now I have drawer nav item table in the shared props file but feels like it shouldn't be here. Should this just be moved directly to drawer nav item md file?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Visit the preview URL for this PR (updated for commit e985da3):

https://blui-react-docs--pr843-fix-blui-5255-missin-xly8ztt6.web.app

(expires Thu, 08 Feb 2024 21:14:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (542731f) 84.03% compared to head (e985da3) 84.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #843   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files          58       58           
  Lines        1234     1234           
  Branches      158      158           
=======================================
  Hits         1037     1037           
  Misses         98       98           
  Partials       99       99           
Flag Coverage Δ
unittests 84.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@surajeaton surajeaton merged commit 976ae15 into dev Feb 8, 2024
17 checks passed
@surajeaton surajeaton deleted the fix/blui-5255-missing-props branch February 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

chevron is not mentioned in Drawer shared props on dev doc
2 participants