Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blui 5050 env inputs #841

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Fix blui 5050 env inputs #841

merged 6 commits into from
Feb 5, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Feb 5, 2024

Fixes blui 5050 - update environment vars for react & react-dev

Changes proposed in this Pull Request:

  • update conditional environment vars

Screenshots / Screen Recording (if applicable)

To Test:

from checkout >
image

to build >
image

or you can download the build artifact if you want to explore the same criteria for Env. Vars set
https://github.com/etn-ccis/blui-react-component-library/actions/runs/7787330699

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Visit the preview URL for this PR (updated for commit 8f96586):

https://blui-react-docs--pr841-fix-blui-5050-env-in-l5j0tcyv.web.app

(expires Wed, 07 Feb 2024 16:08:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48db038) 84.03% compared to head (89df311) 84.03%.
Report is 3 commits behind head on dev.

❗ Current head 89df311 differs from pull request most recent head 8f96586. Consider uploading reports for the commit 8f96586 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #841   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files          58       58           
  Lines        1234     1234           
  Branches      158      158           
=======================================
  Hits         1037     1037           
  Misses         98       98           
  Partials       99       99           
Flag Coverage Δ
unittests 84.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffGreiner-eaton JeffGreiner-eaton marked this pull request as ready for review February 5, 2024 16:42
@joebochill joebochill merged commit 542731f into dev Feb 5, 2024
12 checks passed
@joebochill joebochill deleted the fix/blui-5050-env-inputs branch February 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants