Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Width Knob to HeroBanner Story #192

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Add Width Knob to HeroBanner Story #192

merged 4 commits into from
Sep 1, 2020

Conversation

emclaug2
Copy link
Contributor

@emclaug2 emclaug2 commented Sep 1, 2020

Changes proposed in this Pull Request:

  • Add a border around the HeroBanner so we can see it.
  • Add a width knob to control the width.

huayunh
huayunh approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Can you make the range start from min 350 instead? Unless you want to show how the heroes can get eclipsed
image

@huayunh huayunh merged commit 4d2f426 into dev Sep 1, 2020
@huayunh huayunh deleted the feature/banner-width-knob branch September 1, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huayunh huayunh huayunh approved these changes

@jeffvg jeffvg Awaiting requested review from jeffvg

@joebochill joebochill Awaiting requested review from joebochill

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emclaug2 @huayunh