Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLUI-4717: added 9 new icons #307

Merged
merged 9 commits into from
Feb 15, 2024
Merged

BLUI-4717: added 9 new icons #307

merged 9 commits into from
Feb 15, 2024

Conversation

huayunh
Copy link
Contributor

@huayunh huayunh commented Feb 14, 2024

Fixes BLUI-4717, fixes #308

Changes proposed in this Pull Request:

  • Added 9 new icons: Ethernet Port, Skillet, Skillet Cooktop, Cooking, Stockpot, Stove, Wind Turbine, Water Energy, IOT Scene.
  • Replaced Tom with Ekta in the code owners.

Screenshots / Screen Recording (if applicable)

image

To Test:

  • Verify that all the icon files have been correctly generated for each package (SVG, mui, PNG, rn-vector, icon font)
  • yarn && yarn start
  • fixed now Normally you would do yarn start. But for some reason yarn start does not work on my machine (Unable to run React demo #308)

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 14, 2024
@ektaghag-eaton
Copy link
Contributor

I am also getting same error mentioned here.

@joebochill
Copy link
Collaborator

See the fix for the issue here: #308 (comment)

@joebochill
Copy link
Collaborator

Your branch will run after you bump the react-router dependency versions and then run:

yarn install && yarn build && yarn update:demo && yarn start

update:demo makes sure that the demo project is updated to use the newest version of the packages you create when you build them.

@huayunh
Copy link
Contributor Author

huayunh commented Feb 14, 2024

It worked! Let me ensure to capture that in the readme.

@ektaghag-eaton
Copy link
Contributor

ektaghag-eaton commented Feb 15, 2024

Able to see mentioned icons under /mui and /font 👍 .

@ektaghag-eaton ektaghag-eaton merged commit 2267429 into dev Feb 15, 2024
1 check passed
@ektaghag-eaton ektaghag-eaton deleted the feature/4717-new-icon branch February 15, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

Unable to run React demo
3 participants