R30 Release Announcement #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojleaton
requested review from
joebochill,
huayunh,
JeffGreiner-eaton and
surajeaton
as code owners
github-actions
bot
added
the
brightlayer-ui
|
Visit the preview URL for this PR (updated for commit f460156): https://blui-doc-it--pr722-feature-5150-r30-rel-m0ygx7up.web.app (expires Fri, 26 Jan 2024 05:23:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 590ed6fb71e127776beff0a05819e22fd4307b8f |
huayunh
reviewed
Jan 19, 2024
There was a problem hiding this comment.
- I wonder if this should be BLUI 4.0.
- The phrase "Material Design 3" is repeated three times in the summary. Consider making it more succinct.
- Avoid saying
@brightlayer-ui/colors/branding package, as this is confusing. - Your "package summary" section is not used correctly. We divided it by frameworks so that React devs will read only react-related stuff. Some shared things, like templates, colors, and icons, are grouped together. Though it would be beneficial to call out the two deprecated packages.
- For the "5 new components have been added" line, the components need to be linked to dev doc.
- I am personally not a fan of "as per". I think there's only "per" or "according to" in modern American English.
- Changelogs need to link to the master branch.
huayunh
reviewed
Jan 23, 2024
Co-authored-by: huayunh <[email protected]>
ektaghag-eaton
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #BLUI-5150 .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?