Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added overline, chip, grade, iconswitch and removed typography from c… #719

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Added overline, chip, grade, iconswitch and removed typography from c… #719

merged 1 commit into from
Jan 3, 2024

Conversation

surajeaton
Copy link
Contributor

@surajeaton surajeaton commented Dec 29, 2023 •
edited
Loading

…atalog

Fixes # BLUI-5062

Changes proposed in this Pull Request:

  • Added Chip, Grade, IconSwitch and Overline components from react native to component catalog
  • Removed Typography from react native to component catalog

Screenshots / Screen Recording (if applicable)

Screenshot 2023-12-29 at 3 08 14 PM (2)

To Test:

  • yarn start

Any specific feedback you are looking for?

Note: The storybook links for react native components will be broken for now

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Dec 29, 2023
@surajeaton surajeaton changed the title Added overline, chup, grade, iconswitch and removed typography from c… Added overline, chip, grade, iconswitch and removed typography from c… Dec 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 00bb76f):

https://blui-doc-it--pr719-feature-5062-update-m1lpmoyg.web.app

(expires Thu, 04 Jan 2024 12:52:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 590ed6fb71e127776beff0a05819e22fd4307b8f

@surajeaton surajeaton mentioned this pull request Dec 29, 2023
Merged
@surajeaton
Copy link
Contributor Author

Closing this PR, as it will be blocked until we publish new react native component package.

@surajeaton surajeaton closed this Dec 29, 2023
@surajeaton surajeaton reopened this Jan 2, 2024
@huayunh
Copy link
Contributor

huayunh commented Jan 2, 2024 •
edited
Loading

Can you take a look at why the build is failing and maybe fix it, perhaps in another PR?

@surajeaton surajeaton merged commit 08a0b1a into dev Jan 3, 2024
6 of 7 checks passed
@surajeaton surajeaton deleted the feature/5062-update-doc-it-component-catalog branch January 3, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huayunh huayunh huayunh approved these changes

@joebochill joebochill Awaiting requested review from joebochill joebochill is a code owner

@JeffGreiner-eaton JeffGreiner-eaton Awaiting requested review from JeffGreiner-eaton JeffGreiner-eaton is a code owner

@manojleaton manojleaton Awaiting requested review from manojleaton

@ektaghag-eaton ektaghag-eaton Awaiting requested review from ektaghag-eaton ektaghag-eaton is a code owner

@ArshdeepSingh3-eaton ArshdeepSingh3-eaton Awaiting requested review from ArshdeepSingh3-eaton

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajeaton @huayunh