Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed colors branding package from developer resources #713

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

surajeaton
Copy link
Contributor

Fixes # BLUI-4953

Changes proposed in this Pull Request:

  • Removed branding package from developer resources

Screenshots / Screen Recording (if applicable)

Screenshot 2023-11-28 at 3 24 39 PM

To Test:

  • yarn start
  • Navigate to Resources -> Developer Resources

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Nov 28, 2023
huayunh
huayunh previously approved these changes Nov 28, 2023
@huayunh huayunh dismissed their stale review November 28, 2023 17:25

found something

Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it, can you also change the line that says
Brightlayer UI themes for @brightlayer-ui/react-native-components to say Brightlayer UI themes for React Native Paper for consistency? Thanks.

src/__configuration__/resources/index.tsx Outdated Show resolved Hide resolved
@surajeaton surajeaton requested a review from huayunh November 29, 2023 08:37
@huayunh
Copy link
Contributor

huayunh commented Nov 29, 2023

no clue about the ci stuff

@huayunh huayunh merged commit 3dd1963 into dev Nov 29, 2023
0 of 3 checks passed
@huayunh huayunh deleted the feature/4953-remove-colors-branding-from-dev-resources branch November 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants