Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MD3 component stickersheet to design resources #707

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Add MD3 component stickersheet to design resources #707

merged 4 commits into from
Oct 10, 2023

Conversation

huayunh
Copy link
Contributor

@huayunh huayunh commented Oct 9, 2023 •
edited
Loading

Changes proposed in this Pull Request:

  • Added a link to the new Material Design 3 component sticker sheet
  • Codeowner, replace Tom with Suraj

Screenshots / Screen Recording (if applicable)

Screenshot 2023-10-09 at 4 40 44 PM

To Test:

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Oct 9, 2023
@huayunh
Copy link
Contributor Author

huayunh commented Oct 9, 2023

Why did firebase deploy pass during the first commit but failed the following two?

ektaghag-eaton
ektaghag-eaton approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working fine 👍.

Screenshot 2023-10-10 at 11 32 40 AM

src/__configuration__/design/resources.tsx Outdated Show resolved Hide resolved
surajeaton
surajeaton reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we point home page Figma Sticker Sheet to material design 3 style?
Currently, it is point to material design 2 style.

Screenshot 2023-10-10 at 12 19 57 PM

@huayunh
Copy link
Contributor Author

huayunh commented Oct 10, 2023 •
edited
Loading

Shall we point home page Figma Sticker Sheet to material design 3 style?

I think we are not there yet, considering that the rest of docit is still in Material Design 2

@huayunh huayunh merged commit 2ce5d82 into dev Oct 10, 2023
0 of 2 checks passed
@huayunh huayunh deleted the feature/include-figma-sticker-sheet-in-design-resources branch October 10, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajeaton surajeaton surajeaton left review comments

@JeffGreiner-eaton JeffGreiner-eaton JeffGreiner-eaton approved these changes

@joebochill joebochill Awaiting requested review from joebochill joebochill is a code owner

@daileytj daileytj Awaiting requested review from daileytj

@aubreyhthompson aubreyhthompson Awaiting requested review from aubreyhthompson

@manojleaton manojleaton Awaiting requested review from manojleaton

@ektaghag-eaton ektaghag-eaton Awaiting requested review from ektaghag-eaton ektaghag-eaton is a code owner

@ArshdeepSingh3-eaton ArshdeepSingh3-eaton Awaiting requested review from ArshdeepSingh3-eaton

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huayunh @JeffGreiner-eaton @surajeaton @ektaghag-eaton