Remove "X" from the search field #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huayunh
requested review from
daileytj,
emclaug2 and
joebochill
as code owners
|
I think this is a chrome thing and I don't see it in FireFox. Right now in this branch I can search without seeing the double close now but the search stops and places a "?" in the url without the entire route search "?&search=theme" weird one docit-search.mov |
emclaug2
reviewed
Jan 17, 2022
| @@ -34,6 +34,13 @@ q:after { | |||
| padding: 0; | |||
| } | |||
|
|
|||
| input[type='search']::-webkit-search-decoration, | |||
This is specific to firefox? If the search is being impacted in some way could you log an issue for this? Approving this because the X is gone for me on Chrome. |
emclaug2
approved these changes
Jan 17, 2022
|
Great catch, jeff! Removed the "form" HTML tag that is clearly not compatible with single page apps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Screenshots:
Before:
Screen.Recording.2022-01-17.at.12.49.04.PM.mov
After:
Screen.Recording.2022-01-17.at.12.49.48.PM.mov
To Test: