Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width changing per framework on resource page #320

Merged
merged 1 commit into from
Dec 26, 2020

Conversation

emclaug2
Copy link
Contributor

Fixes #316

Changes proposed in this Pull Request:

  • Adds style to prevent resource page from having dynamic width for each framework tab.

Hosted here: https://pxblue-docit.web.app/resources

@emclaug2 emclaug2 requested a review from huayunh December 21, 2020 14:40
Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hosting it on firebase :)

@emclaug2
Copy link
Contributor Author

emclaug2 commented Dec 21, 2020

This build failed because https://materialdesignicons.com/ is down; AFAIK this is still the correct site and first result if you do a google search for "material design community icons". I think we can just re-run this build later in the day to get this thing merged in.

@huayunh
Copy link
Contributor

huayunh commented Dec 21, 2020

Just checked and that webpage is still down.

@huayunh huayunh merged commit 423b68e into dev Dec 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug/316-resource-page-resizes branch December 26, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Resources page change list item width on different frameworks
2 participants