-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3448 hero examples #489
Conversation
Visit the preview URL for this PR (updated for commit facf6ec): https://blui-angular-docs--pr489-feature-3448-hero-ex-rlsdemd6.web.app (expires Sat, 10 Sep 2022 12:37:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
I took out the border but the divider prop does not seem to be working. Funnily enough this is something that we haven't even demoed in our older storybook.
There needs to be some discussion around what the intro section says / looks like & whether we can re-use it between pages. |
src/docs/pages/component-docs/components/hero/examples/channel-value-children.component.ts
Outdated
Show resolved
Hide resolved
…-value-children.component.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you log an issue for the Hero Banner divider?
Added a new issue for the divider prop issue: https://github.com/brightlayer-ui/angular-component-library/issues/491 |
The intended style shall be
The
is off |
Ooof, I was looking at an older version of the deployed site. Looking good now! |
Changes proposed in this Pull Request: