Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3448 hero examples #489

Merged
merged 11 commits into from
Sep 8, 2022
Merged

Conversation

emclaug2
Copy link
Contributor

@emclaug2 emclaug2 commented Sep 7, 2022

Changes proposed in this Pull Request:

  • Hero Examples

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Visit the preview URL for this PR (updated for commit facf6ec):

https://blui-angular-docs--pr489-feature-3448-hero-ex-rlsdemd6.web.app

(expires Sat, 10 Sep 2022 12:37:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@emclaug2 emclaug2 changed the base branch from release/dev-docs to feature/3450-app-bar-examples September 7, 2022 15:33
@emclaug2 emclaug2 marked this pull request as ready for review September 7, 2022 15:33
@huayunh
Copy link
Contributor

huayunh commented Sep 7, 2022

  • 1. Hero with ChannelValue Children. I would hide the unit space. Or stylize it as 1h 27m with a space between the hours and the minutes
  • 2. Hero with Icon Size and Image Types. Are bluiWhite and bluiBlue supposed to be some variables imported from somewhere else?
  • 3. Now that I think about it... I think it might actually be better to take icon colors out, since the goal here is to showcase Heros and HeroBanners, not how to colorize icons.
  • 4. Hero with Icon Size and Image Types. There might be a special reason for this, but why is the 3rd row of icons referred to as "web icon" instead of "icon font"?
  • 5. Heroes with a HeroBanner. Was there a reason to use "divider border" here instead of just turning on a bottom divider using the divider property?
  • 6. Doc structure. Similiar to what's commented here.

@emclaug2
Copy link
Contributor Author

emclaug2 commented Sep 8, 2022

  • 5. Heroes with a HeroBanner. Was there a reason to use "divider border" here instead of just turning on a bottom divider using the divider property?

I took out the border but the divider prop does not seem to be working. Funnily enough this is something that we haven't even demoed in our older storybook.

  • 6. Doc structure. Similiar to what's commented here.

There needs to be some discussion around what the intro section says / looks like & whether we can re-use it between pages.

@delete-merged-branch delete-merged-branch bot deleted the branch release/dev-docs September 8, 2022 12:29
@huayunh huayunh changed the base branch from feature/3450-app-bar-examples to release/dev-docs September 8, 2022 12:30
Copy link
Contributor

@huayunh huayunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue for the Hero Banner divider?

@emclaug2
Copy link
Contributor Author

emclaug2 commented Sep 8, 2022

Added a new issue for the divider prop issue: https://github.com/brightlayer-ui/angular-component-library/issues/491

@emclaug2
Copy link
Contributor Author

emclaug2 commented Sep 8, 2022

@huayunh

Are these the intended styles?
image

@huayunh
Copy link
Contributor

huayunh commented Sep 8, 2022

The intended style shall be

  • 1h[space]27m or just
  • 1h27m

The

  • 1[space]h27[space]m

is off

@emclaug2
Copy link
Contributor Author

emclaug2 commented Sep 8, 2022

Ooof, I was looking at an older version of the deployed site. Looking good now!

@emclaug2 emclaug2 merged commit 8d52296 into release/dev-docs Sep 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/3448-hero-examples branch September 8, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants