Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go BLUI #358

Merged
merged 27 commits into from
Nov 3, 2021
Merged

Go BLUI #358

merged 27 commits into from
Nov 3, 2021

Conversation

emclaug2
Copy link
Contributor

@emclaug2 emclaug2 commented Nov 3, 2021

Changes proposed in this Pull Request:

  • This publishes the BLUI ng-component library.

To test out the BLUI components, run yarn start:storybook.

I also converted the angular-showcase-demo repo to BLUI. To test out the BLUI components & BLUI themes, check out the branch below & run yarn && yarn start.
https://github.com/pxblue/angular-showcase-demo/tree/feature/blui

@emclaug2 emclaug2 added the master For PRs going into the master branch label Nov 3, 2021
@emclaug2 emclaug2 requested a review from joebochill as a code owner November 3, 2021 01:33
Copy link
Contributor

@jeffvg jeffvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, do we track the components/README.md refs of pxb later

@emclaug2
Copy link
Contributor Author

emclaug2 commented Nov 3, 2021

looks good, do we track the components/README.md refs of pxb later

I'll make a story for this now in JIRA; most pictures in the react & rn component libraries don't need changed but nearly all of angular's will need updated.

@daileytj
Copy link
Contributor

daileytj commented Nov 3, 2021

Just some things I'm noticing on the showcase that we may want to resolve later or perhaps an audit of this would be nice just to make sure we are using the correct colors as defaults.

These list item tags are hardcoded to have a white background... not sure why but they don't look great on light or dark theme in my humble opinion.
Screen Shot 2021-11-03 at 3 26 45 PM
Screen Shot 2021-11-03 at 3 26 52 PM

Decending character gets cut off of our score card...
Screen Shot 2021-11-03 at 3 27 59 PM

That stop watch icon looks strange to me. Should we be using an outlined variant or something here ¯_(ツ)_/¯
Screen Shot 2021-11-03 at 3 28 24 PM

None of these things are a direct issue with the component library work as far as I can tell so I'll approve this, but we may want to write a story to double check these colors and other potential issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master For PRs going into the master branch
Development

Successfully merging this pull request may close these issues.

6 participants