Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeroBanner divider prop not working #491

Closed
emclaug2 opened this issue Sep 8, 2022 · 0 comments · Fixed by #599
Closed

HeroBanner divider prop not working #491

emclaug2 opened this issue Sep 8, 2022 · 0 comments · Fixed by #599
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected hero-banner Affects Hero Banner Component
Milestone
8.1.0

Comments

@emclaug2
Copy link
Contributor

emclaug2 commented Sep 8, 2022 •
edited
Loading

Describe the bug

The divider property on the <blui-hero-banner> is not working as intended; when divider is set to true, a divider is not displayed below the hereos.

What is the expected behavior?

divider prop on the HeroBanner should work similar to React's implementation.

What are the steps to reproduce?

Run the showcase application locally & on the dashboard page, update the <blui-hero-banner> to use a divider.

Environment

Chrome Windows

Anything else to add?

I would not prioritize this issue anytime soon; if anything I would rather deprecate the <blui-hero-banner> component since it's effectively the same as placing an arbitrary number of <blui-hero> elements in a flex container.
@emclaug2 emclaug2 added bug Something not working as expected needs-review Issues that we would like to revisit/review labels Sep 8, 2022
@emclaug2 emclaug2 mentioned this issue Sep 8, 2022
Merged
@huayunh huayunh added the hero-banner Affects Hero Banner Component label Sep 14, 2022
@ektasawant ektasawant removed the needs-review Issues that we would like to revisit/review label Sep 15, 2022
@emclaug2 emclaug2 changed the title HeroBanner divider prop not working HeroBanner divider prop not working Nov 21, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
@joebochill joebochill added this to the 8.0.1 milestone Feb 20, 2023
@raghavenc5 raghavenc5 mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected hero-banner Affects Hero Banner Component
Milestone
8.1.0
Development

Successfully merging a pull request may close this issue.

Bug/491 herobanner divider not working raghavenc5/blui-angular-component-library
4 participants
@emclaug2 @huayunh @ektasawant @joebochill