Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup + extra checks to prevent possible future crashes #76

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

DonKisser
Copy link
Contributor

No description provided.

@etianl
Copy link
Owner

etianl commented Dec 29, 2024

I do not have the time to implement this at the moment because I have to backport it to all the other builds of trouser. I will check this out in a week or two. Thank you very much!

@DonKisser
Copy link
Contributor Author

Understandable. Thank you for maintaining this addon <3

@I-No-oNe
Copy link

I-No-oNe commented Dec 31, 2024

@DonKisser, why don't u just make a static function that checks if everything is null?

Here is an example from a mod named ClickCrystals that I'm part of its development team:

    public static boolean invalid() {
        return mc == null || mc.player == null || mc.world == null || mc.interactionManager == null || mc.options == null;
    }

Edit:
I believe Metor client has a similar method somewhere....

Copy link
Owner

@etianl etianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thank you very much

@etianl etianl merged commit a335cfd into etianl:main Jan 2, 2025
etianl added a commit that referenced this pull request Jan 6, 2025
**v1.3.9**
CAVE_AIR Update!

## New Modules!

**PortalPatternFinder**
- Scans for the shapes of broken/removed Nether Portals within the cave air blocks found in caves and underground structures in 1.13+ chunks. 
- This may be useful for finding portal skips in the Nether because there is alot of cave generation containing CAVE_AIR. 

**CaveDisturbanceDetector**
- Scans for single air blocks within the cave air blocks found in caves and underground structures in 1.13+ chunks.
- There is alot of false positives with this module due to random single air blocks that can naturally occur in caves, mineshafts, etc.

## Other Changes

- Made detected positions get cleared on switching dimension to prevent the renders still being visible from the previous dimension in the **ActivatedSpawnerDetector** and **PotESP** modules.
- Added an option so you can turn off chat feedback in ActivatedSpawnerDetector and BaseFinder.
- Added an option enabled by default to **ActivatedSpawnerDetector** which scans for disturbances in the air around the spawner blocks if the timer value is 20 or 0. If someone placed a block and removed it immediately around the spawner this will detect that within chunks generated in Minecraft version 1.13+.
- Added an option for tracers to **PotESP** and **ActivatedSpawnerDetector**. This also includes an option to only show one tracer to the nearest detected thing. 
- Made the small box around the spawner and the tracer still render when no chests within are in range of spawner when "Less Render Spam" is enabled in **ActivatedSpawnerDetector**.
- Merged this pull request #76 that cleaned up a bunch of my code with 40 files changed! Thank you to https://github.com/DonKisser for their contributions!
etianl added a commit that referenced this pull request Jan 6, 2025
**v1.3.9**
CAVE_AIR Update!

## New Modules!

**PortalPatternFinder**
- Scans for the shapes of broken/removed Nether Portals within the cave air blocks found in caves and underground structures in 1.13+ chunks. 
- This may be useful for finding portal skips in the Nether because there is alot of cave generation containing CAVE_AIR. 

**CaveDisturbanceDetector**
- Scans for single air blocks within the cave air blocks found in caves and underground structures in 1.13+ chunks.
- There is alot of false positives with this module due to random single air blocks that can naturally occur in caves, mineshafts, etc.

## Other Changes

- Made detected positions get cleared on switching dimension to prevent the renders still being visible from the previous dimension in the **ActivatedSpawnerDetector** and **PotESP** modules.
- Added an option so you can turn off chat feedback in ActivatedSpawnerDetector and BaseFinder.
- Added an option enabled by default to **ActivatedSpawnerDetector** which scans for disturbances in the air around the spawner blocks if the timer value is 20 or 0. If someone placed a block and removed it immediately around the spawner this will detect that within chunks generated in Minecraft version 1.13+.
- Added an option for tracers to **PotESP** and **ActivatedSpawnerDetector**. This also includes an option to only show one tracer to the nearest detected thing. 
- Made the small box around the spawner and the tracer still render when no chests within are in range of spawner when "Less Render Spam" is enabled in **ActivatedSpawnerDetector**.
- Merged this pull request #76 that cleaned up a bunch of my code with 40 files changed! Thank you to https://github.com/DonKisser for their contributions!
etianl added a commit that referenced this pull request Jan 6, 2025
**v1.3.9**
CAVE_AIR Update!

## New Modules!

**PortalPatternFinder**
- Scans for the shapes of broken/removed Nether Portals within the cave air blocks found in caves and underground structures in 1.13+ chunks. 
- This may be useful for finding portal skips in the Nether because there is alot of cave generation containing CAVE_AIR. 

**CaveDisturbanceDetector**
- Scans for single air blocks within the cave air blocks found in caves and underground structures in 1.13+ chunks.
- There is alot of false positives with this module due to random single air blocks that can naturally occur in caves, mineshafts, etc.

## Other Changes

- Made detected positions get cleared on switching dimension to prevent the renders still being visible from the previous dimension in the **ActivatedSpawnerDetector** and **PotESP** modules.
- Added an option so you can turn off chat feedback in ActivatedSpawnerDetector and BaseFinder.
- Added an option enabled by default to **ActivatedSpawnerDetector** which scans for disturbances in the air around the spawner blocks if the timer value is 20 or 0. If someone placed a block and removed it immediately around the spawner this will detect that within chunks generated in Minecraft version 1.13+.
- Added an option for tracers to **PotESP** and **ActivatedSpawnerDetector**. This also includes an option to only show one tracer to the nearest detected thing. 
- Made the small box around the spawner and the tracer still render when no chests within are in range of spawner when "Less Render Spam" is enabled in **ActivatedSpawnerDetector**.
- Merged this pull request #76 that cleaned up a bunch of my code with 40 files changed! Thank you to https://github.com/DonKisser for their contributions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants