Create apps.py #876
Merged
Create apps.py #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves etianen#873
|
Interesting. I think BigAutoField is the correct choice here, but won't that also require a migration to be added? I think for the time being keeping it as AutoField is safer. I've found some bugs in the migration Django generates for this in some of my work projects. |
Changed BigAutoField to AutoField to prevent migrations
|
In the PR I've changed the BigAutoField to AutoField. Also, the workflow was cancelled due to Flake8 error. This has been resolved as well. |
|
Merged, thanks! The tests are failing for an unrelated issue: psycopg/psycopg2#1293 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #873.
By adding an AppConfig, one can set the
default_auto_field. The other parameters of the AppConfig are chosen so the behaviour for other installations remains unchanged.