Drop Python 2 support #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be mandatory to support Django 3.0 (unless we add more compatiblity shims). |
|
Very nice. I suspect there'll be a few more places where the code can be cleaned up without the requirement to support Python 2, Django < 3.0, but this is a great start. I think that following Django's advice to drop Django <3.0 support and Python 2 probably merits a breaking release (v3.0?), so if there's anything else you can see that will cut out compatibility shims, I'd love a PR. |
|
For now I didn't see yet a compelling reason to drop support for older Django version, but it might occur when adding support for Django 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.