Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django-reversion 3.0.8 compatibility with Django 1.11 #857

Closed
erikrw opened this issue Jan 22, 2021 · 5 comments
Closed

django-reversion 3.0.8 compatibility with Django 1.11 #857

erikrw opened this issue Jan 22, 2021 · 5 comments

Comments

@erikrw
Copy link
Contributor

erikrw commented Jan 22, 2021

Hi,

There's a mismatch between pypi/setup.py

django-reversion/setup.py

Line 38 in 4765d97

"django>=1.11",
which says that django-reversion 3.0.8+ require Django 1.11+

and Read the docs/CHANGELOG.rst https://github.com/etianen/django-reversion/blob/master/CHANGELOG.rst#308---2020-08-31 which says Django 1.11 LTS support has been dropped.

Which one is correct?
@etianen
Copy link
Owner

etianen commented Jan 22, 2021 via email

@erikrw
Copy link
Contributor Author

erikrw commented Jan 22, 2021

Cool. In that case, should https://github.com/etianen/django-reversion/blob/master/README.rst#requirements also be updated?

@etianen
Copy link
Owner

etianen commented Jan 24, 2021 via email

@erikrw
Copy link
Contributor Author

erikrw commented Jan 24, 2021

Done. (I wasn't sure what the next supported version would be among 2.0/2.1/2.2, but I see 2.0 in setup.py)

@etianen
Copy link
Owner

etianen commented Jan 25, 2021

Thanks, and merged! Any other issue you see, drop in a new MR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etianen @erikrw