Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

507- adds DRP GET data rights endpoint #526

Merged
merged 9 commits into from
May 25, 2022
Merged

507- adds DRP GET data rights endpoint #526

merged 9 commits into from
May 25, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented May 18, 2022 •
edited
Loading

Purpose

Adds DRP Get data rights endpoint

Changes

  • Adds GET data rights endpoint
  • Adds appropriate tests
  • Updates postman collection

Checklist

  • Update CHANGELOG.md file in appropriate sections
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #507

conceptualshark
conceptualshark previously requested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise from a docs standpoint 👍

@seanpreston seanpreston self-assigned this May 24, 2022
seanpreston
seanpreston suggested changes May 24, 2022
View reviewed changes
Copy link
Contributor

@seanpreston seanpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eastandwestwind — a few minor changes and some conflicts to fix!

@eastandwestwind
Copy link
Contributor Author

Back over to you @seanpreston / @conceptualshark !

@seanpreston seanpreston dismissed conceptualshark’s stale review May 25, 2022 17:22

Concerns addressed

@seanpreston seanpreston merged commit 164a7e0 into main May 25, 2022
@seanpreston seanpreston deleted the 507-drp-get-data-rights branch May 25, 2022 17:22
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@eastandwestwind
507- adds DRP GET data rights endpoint (#526)
935e7fd 
* 507- adds DRP GET data rights endpoint

* updates changelog

* format

* Adds to DRP docs

* cr

* import sorting

* use drpaction enum in tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seanpreston seanpreston seanpreston approved these changes

@conceptualshark conceptualshark conceptualshark left review comments

Assignees

@seanpreston seanpreston

@conceptualshark conceptualshark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DRP] Add support for GET /data-rights endpoint
3 participants
@eastandwestwind @seanpreston @conceptualshark