This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
397 denial reason for dsr #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice work @TheAndrewJackson ! Your code is super easy to read, and I got to learn some new things about SQLAlchemy cascades.
Just a couple Qs / comments.
adamsachs
pushed a commit
to adamsachs/fidesops_forked_test
that referenced
this pull request
May 17, 2022
* Add audit log for denial reasons * Add audit log tests * Update migration down revision * Fix black formatting * Update documentation * Add PR feedback * clarify denial reason docs Co-authored-by: Cole Isaac <[email protected]>
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Add audit log for denial reasons * Add audit log tests * Update migration down revision * Fix black formatting * Update documentation * Add PR feedback * clarify denial reason docs Co-authored-by: Cole Isaac <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the ability to attach a denial reason to denied privacy requests
Changes
AuditLogtableChecklist
Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #397