This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
414- adds DRP action to Policy #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastandwestwind
force-pushed
the
414-drp-action
branch
from
2b6bfd0
to
c903cc2
Compare
|
Lint failing due to known issue on |
eastandwestwind
force-pushed
the
414-drp-action
branch
from
c903cc2
to
3a97760
Compare
seanpreston
reviewed
May 5, 2022
seanpreston
reviewed
May 5, 2022
seanpreston
suggested changes
May 5, 2022
There was a problem hiding this comment.
Mostly there, a couple of minor changes around how the validation works required. Thanks @eastandwestwind
|
Thanks for the review @seanpreston! Just need some additional input from you, above |
|
Spoke with @adriaaaa about the docs changes - I ended up doing some cleanup and will break out some additional documentation in a new ticket, so this is good from me. 👍 |
seanpreston
reviewed
May 6, 2022
| @classmethod | ||
| def create_or_update(cls, db: Session, *, data: Dict[str, Any]) -> FidesopsBase: | ||
| """Overrides base create or update to add custom error for drp action already exists""" | ||
| db_obj = cls.get_by_key_or_id(db=db, data=data) |
There was a problem hiding this comment.
Thanks for making this change!
|
Ok, ready to go again @seanpreston! |
seanpreston
approved these changes
May 7, 2022
adamsachs
pushed a commit
to adamsachs/fidesops_forked_test
that referenced
this pull request
May 17, 2022
* adds drp action type to db, adds docs, tests * fix lint, tests * format * remove unneeded func arg * lint * more lint * CR changes * update alembic down migration number * minor docs updates for drp * integration tests and updating alembic * catches integrity error at endpoint level * lint Co-authored-by: Cole Isaac <[email protected]>
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* adds drp action type to db, adds docs, tests * fix lint, tests * format * remove unneeded func arg * lint * more lint * CR changes * update alembic down migration number * minor docs updates for drp * integration tests and updating alembic * catches integrity error at endpoint level * lint Co-authored-by: Cole Isaac <[email protected]>
dependabot bot
added a commit
that referenced
this pull request
Sep 23, 2022
* adds drp action type to db, adds docs, tests * fix lint, tests * format * remove unneeded func arg * lint * more lint * CR changes * update alembic down migration number * minor docs updates for drp * integration tests and updating alembic * catches integrity error at endpoint level * lint Co-authored-by: Cole Isaac <[email protected]>
dependabot bot
added a commit
that referenced
this pull request
Sep 23, 2022
* adds drp action type to db, adds docs, tests * fix lint, tests * format * remove unneeded func arg * lint * more lint * CR changes * update alembic down migration number * minor docs updates for drp * integration tests and updating alembic * catches integrity error at endpoint level * lint Co-authored-by: Cole Isaac <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds ability to add DRP Action to any given Policy.
Changes
Checklist
Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #414