Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setuptools to dev-requirements to fix versioneer error #983

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Add setuptools to dev-requirements to fix versioneer error #983

merged 2 commits into from
Aug 12, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Aug 12, 2022 •
edited
Loading

Closes

Code Changes

  • Add setuptools >= 64.0.2 to dev requirements

Steps to Confirm

  • run nox -s "build(dev)"

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

setuptools 64.0.2 includes a fix to the editable install error with versioneer.

@sanders41 sanders41 requested a review from a team August 12, 2022 16:41
@ThomasLaPiana
Copy link
Contributor

I'm not sure why but my build works totally fine on main, checked the container and setuptools is at version 58 something 🤷

ThomasLaPiana
ThomasLaPiana approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 👍

@sanders41 sanders41 merged commit 710f843 into main Aug 12, 2022
@sanders41 sanders41 deleted the setuptools branch August 12, 2022 17:19
@rsilvery rsilvery mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanders41 @ThomasLaPiana