Nest the UI directory into a ctl subdir
#970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
suggested changes
Aug 10, 2022
There was a problem hiding this comment.
I believe this line in package.json will also need to be updated to add one more ../ https://github.com/ethyca/fides/blob/main/clients/admin-ui/package.json#L17
allisonking
approved these changes
Aug 11, 2022
|
known bugs happening with the external tests as well as the docs build, merging regardless of the failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #952
Code Changes
Steps to Confirm
Pre-Merge Checklist
Relevant Follow-Up Issues CreatedCHANGELOG.mdDescription Of Changes
A quick update that nests the UI down one level so it won't conflict with merging the fidesops UI