Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fideslib to 3.0.1 and remove patch code #931

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Bump fideslib to 3.0.1 and remove patch code #931

merged 4 commits into from
Jul 21, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jul 21, 2022

Closes

Code Changes

  • Bump fideslib to 3.0.1
  • Remove the patching of SCOPES which added USER_PASSWORD_RESET since it is now coming from fideslib

Steps to Confirm

  • Run test suite

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

The USER_PASSWORD_RESET scope was missing form the SCOPES list so I temporarily patched the list with the value. v3.0.1 now contains the value so the patch is no longer needed.

@sanders41 sanders41 requested a review from a team July 21, 2022 12:38
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch in the first and easy cleanup 🙌🏽

@sanders41 sanders41 merged commit 61fbcc7 into main Jul 21, 2022
@sanders41 sanders41 deleted the fideslib branch July 21, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants