Remove duplicate API_PREFIX #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasLaPiana
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Code Changes
API_PREFIXfrom fidesctl/core/utils.py and change references toAPI_PREFIXin fidesctl/api/reoutes/util.pySteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
API_PREFIXwas originally duplicated in fidesctl/core/utils.py because theapiwas installed as an extra, and when it was not installed theAPI_PREFIXwas not available causing an error. Now thatapihas been moved into fidesctl and is always included this is no longer needed, and removing the duplicate makes maintenance easier.