-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxonomy nested dropdown #910
Conversation
cf65d86
to
ac8ca2b
Compare
c2a8663
to
71bf4e9
Compare
ready for review now! |
@allisonking my only nit here is that I think a better UX would be to have an accordion sound play every single time this dropdown is used |
@allisonking I'm getting this error here, going to try nuking it and restarting:
|
got it fixed, just had to wipe out my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change! The accordion has a great mouse feel, and i love how it fades in as it expands 🚀
Closes #853
Code Changes
parent_key
: they are not nested. So I had to updatetransformTaxonomyEntityToNodes
to be able to handle when a thing is not actually nested.Steps to Confirm
/taxonomy
and click around the accordionPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Only thing outstanding is this bit of CSS I'm struggling with: #910 (comment)
Other than that, good to review!
Screen.Recording.2022-07-18.at.4.13.58.PM.mov