Integrate generating a dataset from a database connection #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829
Code Changes
/generate
endpoint from dataset.slice.tsSteps to Confirm
postgresql://postgres:[email protected]:6432/flaskr
(because of docker networking stuff)Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
One thing I'm not sure how to approach is that we need an organization key to use the generate endpoint. I hard coded
default_organization
for now, but I'm not sure how we plan to go about getting that in the future (potentially related to config UI work? is it possible we can always have an organization key around, similar to how we'd have a user around?)Success state
Screen.Recording.2022-07-11.at.5.21.21.PM.mov
Errors
Untitled.mov
Error if the string just doesn't work (not sure if the backend can give a better error than just a 500, or if there's any validation we should do on the frontend before sending it over)