Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete dataset field and collection #762

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Delete dataset field and collection #762

merged 4 commits into from
Jun 16, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 14, 2022 •
edited
Loading

Closes #705

Code Changes

  • Add delete button to dataset field and dataset collection editing
  • Add functions to help delete fields and datasets

Steps to Confirm

  • Edit a dataset field or collection, then click the trash can icon to delete it

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Deleting a collection:

Screen.Recording.2022-06-14.at.4.37.56.PM.mov

Deleting a dataset field:

Screen.Recording.2022-06-14.at.4.57.05.PM.mov

Simon is still working on a delete confirmation design, so for now, that trash can icon is a little dangerous :)

@allisonking allisonking force-pushed the aking-705-delete-dataset-field branch from 7280c8d to 19fa1e7 Compare June 15, 2022 16:15
@allisonking allisonking marked this pull request as ready for review June 15, 2022 16:38
@allisonking allisonking requested a review from LKCSmith June 15, 2022 16:38
This was referenced Jun 15, 2022
Closed
Closed
LKCSmith
LKCSmith approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@allisonking allisonking merged commit 91f3570 into main Jun 16, 2022
@allisonking allisonking deleted the aking-705-delete-dataset-field branch June 16, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKCSmith LKCSmith LKCSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a button to delete a field from a dataset
2 participants
@allisonking @LKCSmith