-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make webserver resilient to database not starting up #649
Conversation
Would love some eyes on this to make sure I'm going in the right direction with how I interpreted the ticket. I'm doing some Also I am getting destroyed by this unit test. I'm trying to mock a call and have not been succeeding, and then I discovered FastAPI mocks are kind of weird but I still haven't successfully mocked the call. |
I'm having trouble figuring out the failing test. It does fail locally for me too, but I'm having trouble seeing what the Internal Server Error is. I'm running |
@allisonking I'll take a look and get this over the line, I have a hunch of what it is but its hard to articulate (its a weird endpoint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @allisonking thanks!
Closes #562
Code Changes
Steps to Confirm
nox -s api
localhost:8080/api/v1/health
and confirm that the database is unhealthyPre-Merge Checklist
CHANGELOG.md
Description Of Changes
This PR updates how the webserver initializes so that even if the database is unreachable, the webserver is still able to spin up. The health command has also been updated to return various health statuses to provide better debugging for users.