Send property id and also override path. #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5532/merge
|
| Run status |
|
| Run duration | 00m 41s |
| Commit |
|
| Committer | Tom Van Dort |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
tvandort
commented
Nov 22, 2024
| @@ -16,7 +16,9 @@ const loadEnvironmentVariables = () => { | |||
| "file:///app/config/config.css", | |||
| SHOW_BRAND_LINK: | |||
| process.env.FIDES_PRIVACY_CENTER__SHOW_BRAND_LINK === "true" || false, | |||
| CUSTOM_PROPERTIES: process.env.CUSTOM_PROPERTIES === "true" || true, | |||
| CUSTOM_PROPERTIES: process.env.CUSTOM_PROPERTIES !== "false", // default: true | |||
There was a problem hiding this comment.
I'm not sure I understand the "why" behind this change, can you elaborate?
There was a problem hiding this comment.
Fixing a bug I noticed. || true will always be true even if you set it to "false". So I fix that.
It shouldn't matter too much, the default is true and I doubt anyone will set it to false. But just in case I wanted to fix it.
added 2 commits
November 22, 2024 15:27
…to-experience-and-experiment-with-manual-override
lucanovera
approved these changes
Nov 22, 2024
lucanovera
deleted the
pass-property-id-to-experience-and-experiment-with-manual-override
branch
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Tom Van Dort |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
lucanovera
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Lucano Vera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fetch correct experience when a privacy center property is being use. Add env variable to override use a specific property for the root domain (when no property paths are used).
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated