Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include manage label in TCF experience #5528

Merged
merged 2 commits into from
Nov 21, 2024
Merged

include manage label in TCF experience #5528

merged 2 commits into from
Nov 21, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 21, 2024 •
edited
Loading

Closes HJ-253

include manage label in TCF experience

Steps to Confirm

  1. Visit Experience page in Admin UI
  2. Click through to a TCF experience
  3. Click "English" to open translations
  4. Ensure "Manage privacy preferences" button label is an option

CleanShot 2024-11-21 at 12 36 00@2x

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 7:38pm

@cypress Cypress
Copy link

cypress bot commented Nov 21, 2024 •
edited
Loading

fides    Run #11135

Run Properties:  status check passed Passed #11135  •  git commit 7208e1a012 ℹ️: Merge 5df8643359bf98f1a93d6b3f6fb2caee15536d18 into b4bbcf542174b9576888d03c4fba...
Project fides
Branch Review refs/pull/5528/merge
Run status status check passed Passed #11135
Run duration 00m 40s
Commit git commit 7208e1a012 ℹ️: Merge 5df8643359bf98f1a93d6b3f6fb2caee15536d18 into b4bbcf542174b9576888d03c4fba...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@gilluminate gilluminate merged commit d1baca9 into main Nov 21, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/HJ-253/fe-tcf-preview-not-available branch November 21, 2024 19:54
gilluminate added a commit that referenced this pull request Nov 21, 2024
@gilluminate
include manage label in TCF experience (#5528)
1f88dc2
@cypress Cypress
Copy link

cypress bot commented Nov 21, 2024

fides    Run #11136

Run Properties:  status check passed Passed #11136  •  git commit d1baca99b5: include manage label in TCF experience (#5528)
Project fides
Branch Review main
Run status status check passed Passed #11136
Run duration 00m 39s
Commit git commit d1baca99b5: include manage label in TCF experience (#5528)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-torres-marroquin andres-torres-marroquin andres-torres-marroquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @andres-torres-marroquin