Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing privacy request received message #5518

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fixing privacy request received message #5518

merged 3 commits into from
Nov 20, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 20, 2024 •
edited
Loading

Closes LA-156

Description Of Changes

Fixing issue where custom identities were not being passed in correctly to the dispatch_message_task.

Steps to Confirm

  1. Add a custom identity to the Privacy Center
"identity_inputs": {
  "email": "required",
  "stack_overflow_id": { "label": "Stack Overflow ID" }
},
  1. Configure a messaging provider
  2. Set FIDES__NOTIFICATIONS__SEND_REQUEST_RECEIPT_NOTIFICATION=true
  3. Submit a privacy request
  4. You should receive a Your privacy request has been received email

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 5:09pm

@cypress Cypress
Copy link

cypress bot commented Nov 20, 2024 •
edited
Loading

fides    Run #11109

Run Properties:  status check passed Passed #11109  •  git commit dcba25053d ℹ️: Merge 8f13decf549e4974953587bf5829bb4d06d7f7ee into 48dc19916f425172d22edc81e278...
Project fides
Branch Review refs/pull/5518/merge
Run status status check passed Passed #11109
Run duration 00m 38s
Commit git commit dcba25053d ℹ️: Merge 8f13decf549e4974953587bf5829bb4d06d7f7ee into 48dc19916f425172d22edc81e278...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

eastandwestwind
eastandwestwind approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, really like the detailed test too!

@galvana galvana merged commit a6e0c86 into main Nov 20, 2024
10 of 14 checks passed
@galvana galvana deleted the LA-156-privacy-request-received-email-is-not-sent-when-custom-field-is-added-to-PC branch November 20, 2024 17:06
@cypress Cypress
Copy link

cypress bot commented Nov 20, 2024

fides    Run #11111

Run Properties:  status check passed Passed #11111  •  git commit a6e0c867d1: Fixing privacy request received message (#5518)
Project fides
Branch Review main
Run status status check passed Passed #11111
Run duration 00m 39s
Commit git commit a6e0c867d1: Fixing privacy request received message (#5518)
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @eastandwestwind